Implement separate storage buckets in flyte-core #4675
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
dosubot
bot
added
size:M
Signed-off-by: davidmirror-ops <[email protected]>
dosubot
bot
added
size:L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4675 +/- ##
==========================================
- Coverage 58.15% 58.14% -0.01%
==========================================
Files 626 626
Lines 53786 53786
==========================================
- Hits 31277 31274 -3
- Misses 20001 20005 +4
+ Partials 2508 2507 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: David Espejo <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
Signed-off-by: David Espejo <[email protected]>
Signed-off-by: davidmirror-ops <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes #4291
Why are the changes needed?
What changes were proposed in this pull request?
This PR introduces a new mandatory field in the flyte-core Helm chart:
userBucketName.By default it can be the same as the
bucketNamebut, if different,userBucketNamewill be used by Flyte to build therawoutput-prefixparameter for propeller and, consequently, Flyte will store raw data there, storing metadata only on the storage container specified inbucketNameHow was this patch tested?
Scenarios tested:
userBucketNamethanbucketName: workflow executions store inputs/outputs in the userBucketNameuserBucketNameasbucketName: workflow executions store both raw data and metadata on the same bucketSetup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link